🤖 feat: add Argo CD single-apply ApplicationSet example#75
Conversation
Add an Argo CD ApplicationSet example that bootstraps CloudNativePG, coder-k8s, a PostgreSQL cluster, and a CoderControlPlane from one manifest. Also add Argo sync-wave annotations to the existing CloudNativePG example manifests so they apply in dependency order, and document both examples in README files. --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.56`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.56 -->
|
@codex review Please review this Argo CD example addition for correctness and deployment ordering. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f35546fcf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refactor the Argo CD example so the ApplicationSet generates one multi-source Application instead of a parent app that applies child Application resources. This avoids cross-Application wave ordering ambiguity, adds a cascading resources finalizer for cleanup, and keeps dependency ordering at the resource level via sync waves. --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.56`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.56 -->
|
@codex review Addressed feedback by refactoring the Argo example to a single multi-source generated Application (no app-of-apps wave dependency), and added a resources finalizer for cascading cleanup. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Add a new Argo CD example that lets users bootstrap CloudNativePG + coder-k8s + PostgreSQL +
CoderControlPlanefrom a singleApplicationSetmanifest.Background
The repository already had a manual CloudNativePG example, but GitOps users had to perform several separate install steps. This change adds a one-apply Argo CD flow aligned with that example so evaluator clusters can stand up quickly.
Implementation
examples/argocd/with:applicationset.yaml(single resource to apply)config/crd/bases,config/rbac,deploy)examples/cloudnativepg)wave 0operators,wave 1app resources).examples/cloudnativepg/:wave 0Clusterwave 1CoderControlPlanewave 2README.mdexamples list now includesexamples/argocd/examples/cloudnativepg/README.mdnow documents shared Argo sync-wave behaviorValidation
make verify-vendormake testmake buildmake lintmake docs-checkyaml.safe_load_allto verify syntax.Risks
targetRevision: mainfor repository-backed Applications, which is intentionally convenient for demos but not pinned for reproducible production installs.Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.56